Skip to content

Conversation

@Nevay
Copy link
Contributor

@Nevay Nevay commented Jan 23, 2026

Resolves #1681 / #1867 (comment).

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 10.08065% with 223 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.40%. Comparing base (6957241) to head (d797ef3).

Files with missing lines Patch % Lines
src/SDK/ConfigEnv/EnvConfiguration.php 0.00% 157 Missing ⚠️
src/SDK/_register.php 0.00% 6 Missing ⚠️
...ogRecordExporterLoaderLogRecordExporterFactory.php 0.00% 5 Missing ⚠️
...lity/MetricExporterLoaderMetricExporterFactory.php 0.00% 5 Missing ⚠️
...ity/ResponsePropagatorLoaderResponsePropagator.php 0.00% 5 Missing ⚠️
...tibility/SpanExporterLoaderSpanExporterFactory.php 0.00% 5 Missing ⚠️
...ility/TextMapPropagatorLoaderTextMapPropagator.php 0.00% 5 Missing ⚠️
src/SDK/ConfigEnv/Trace/SamplerLoaderAlwaysOff.php 0.00% 4 Missing ⚠️
src/SDK/ConfigEnv/Trace/SamplerLoaderAlwaysOn.php 0.00% 4 Missing ⚠️
...figEnv/Trace/SamplerLoaderParentBasedAlwaysOff.php 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1872      +/-   ##
============================================
- Coverage     68.03%   66.40%   -1.64%     
- Complexity     3012     3078      +66     
============================================
  Files           453      467      +14     
  Lines          8819     9027     +208     
============================================
- Hits           6000     5994       -6     
- Misses         2819     3033     +214     
Flag Coverage Δ
8.2 66.29% <10.08%> (-1.66%) ⬇️
8.3 66.35% <10.08%> (-1.61%) ⬇️
8.4 66.25% <10.08%> (-1.73%) ⬇️
8.5 65.43% <10.08%> (-1.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Logs/ExporterFactory.php 100.00% <ø> (ø)
src/SDK/Logs/LoggerProvider.php 100.00% <100.00%> (ø)
src/SDK/Logs/LoggerProviderFactory.php 85.71% <ø> (ø)
src/SDK/Metrics/MeterProviderFactory.php 76.92% <ø> (ø)
src/SDK/Propagation/PropagatorFactory.php 94.11% <ø> (ø)
src/SDK/Propagation/ResponsePropagatorFactory.php 64.70% <ø> (ø)
src/SDK/Registry.php 69.07% <ø> (ø)
src/SDK/SdkAutoloader.php 91.40% <100.00%> (-0.57%) ⬇️
src/SDK/Trace/ExporterFactory.php 100.00% <ø> (ø)
src/SDK/Trace/SamplerFactory.php 100.00% <100.00%> (ø)
... and 19 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6957241...d797ef3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update all env based factory to use EnvComponentLoader instead of using separate factory interfaces for each component.

1 participant