Skip to content

Conversation

@druellan
Copy link
Contributor

@druellan druellan commented Dec 18, 2025

…meters were valid

Chore: consistency in the name of the feature: disabled_tools and not disabledTools

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

disabled_tools feature was not working. Looking at the original code:

    # Validate disabledTools
    disabled_tools = server_cfg.get("disabled_tools")
    if disabled_tools is not None:
        if not isinstance(disabled_tools, list):
            raise ValueError(f"Server '{server_name}' 'disabledTools' must be a list")
        for tool_name in disabled_tools:
            if not isinstance(tool_name, str):
                raise ValueError(f"Server '{server_name}' 'disabledTools' must contain only strings")
        raise ValueError(
            f"Server '{server_name}' must have either 'command' for stdio or 'type' and 'url' for remote servers"
        )

The rise at the end of the if block is always rising an exception if the validation is true, halting the code execution if the disabled_tools parameter is present and valid.

The fix: remove:

        raise ValueError(
            f"Server '{server_name}' must have either 'command' for stdio or 'type' and 'url' for remote servers"
        )

Fixed

The disabled_tools feature is always rising an exception on execution

Chore

Replacing disabledTools for disabled_tools in comments and console messages for consistency


Screenshots or Videos

2025-12-18_10h12_47

…meters were valid

Chore: consistency in the name of the feature: disabled_tools and not disabledTools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant