refactor: extract order query key constant to improve readability and…#585
Open
abhayDoes wants to merge 3 commits intoopenmrs:mainfrom
Open
refactor: extract order query key constant to improve readability and…#585abhayDoes wants to merge 3 commits intoopenmrs:mainfrom
abhayDoes wants to merge 3 commits intoopenmrs:mainfrom
Conversation
… maintainability This PR improves the readability and maintainability of the ApproveLabResultsModal workflow by extracting the SWR mutation key into a dedicated constant. 🔧 Changes Introduced orderQueryKey constant Simplified the SWR mutate predicate from a string prefix check to a direct equality comparison Reduces string duplication and improves type safety Why this change? Makes the intent of the mutation clearer Avoids recomputing a long URL string inline Reduces risk of typos or mismatched strings Easier to reuse in future features or tests This PR does not change any behavior and is safe.
jabahum
reviewed
Jan 24, 2026
Collaborator
jabahum
left a comment
jabahum
left a comment
There was a problem hiding this comment.
@abhayDoes lets fix conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the readability and maintainability of the ApproveLabResultsModal workflow by extracting the SWR mutation key into a dedicated constant.
🔧 Changes
Introduced orderQueryKey constant
Simplified the SWR mutate predicate from a string prefix check to a direct equality comparison Reduces string duplication and improves type safety
Why this change?
Makes the intent of the mutation clearer
Avoids recomputing a long URL string inline
Reduces risk of typos or mismatched strings
Easier to reuse in future features or tests
This PR does not change any behavior and is safe.