NE-2376: Remove restriction of unmanaged x-k8s.io #30658
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@rikatz: This pull request references NE-2376 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test okd-scos-images |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Scheduling required tests: |
|
marking bug as pre-merge-verified as all e2e tests are successful /verified by e2e |
openshift-ci-robot
added
the
verified
|
@rhamini3: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I can take on the review for this since I started looking at it |
|
My comment is more about follow up work, rather than the stated objective of this PR, so: |
openshift-ci
bot
added
lgtm
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 78773b6
New tests seen in this PR at sha: 78773b6
|
|
/lgtm |
openshift-ci-robot
removed
the
verified
|
Thanks for the update |
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
|
Scheduling required tests: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidesalerno, gcs278, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by e2e |
openshift-ci-robot
added
the
verified
|
@rikatz: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rikatz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.20 |
|
@rikatz: new pull request created: #30717 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.21 |
|
/cherry-pick release-4.19 |
|
@rikatz: new pull request created: #30718 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rikatz: new pull request created: #30719 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.