speedtest-netperf: add passphrase option #28373
Open
+38
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
Your commit should start with the subject and end with the sign-off, not the other way around. You commit message lines should be less than 75 characters long. |
Comment on lines
+461
to
+465
| -Z|--passphrase) | ||
| case "$2" in | ||
| "") echo "Missing passphrase" ; exit 1 ;; | ||
| *) PASSPHRASE="$2" ; shift 2 ;; | ||
| esac ;; |
Member
There was a problem hiding this comment.
Does this check work if passphrase is not the last argument, and instead of a passphrase, $2 is the next argument instead? E.g. --passphrase --ping. It looks like this applies to the rest of the arguments as well.
Netperf servers can now optionally have a passphrase for use. The default "netperf.bufferbloat.net/" uses a rotating password that is listed on a webpage hosted on the same domain. Right now, "netperf -H netperf.bufferbloat.net" (the default host) throws "recv_response: partial response received: 0 bytes". As a result, the output of "speedtest-netperf.sh -s" is inaccurate. An optional -Z/--passphrase option has been added to speedtest-netperf.sh which is passed to the -Z option of netperf. The -Z option has been added to usage instructions in script and README.md Warnings have been put in the script's error output and in the README.md to check the server's web page for a passphrase. Signed-off-by: Chris Swingle <[email protected]>
Alchemichai
force-pushed
the
passphrase_support
branch
from
a0d3f66 to
66e251c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @guidosarducci
Description:
speedtest-netperf provides a quick and easy way to test a network's performance under high loads by creating multiple instances of netperf and pinging to check for latency changes under load.
netperf servers can now optionally have a passphrase. The default "netperf.bufferbloat.net/" uses a rotating password that is listed on a webpage hosted on the same domain. Right now,
netperf -H netperf.bufferbloat.net(which speedtest-netperf uses by default) throws "recv_response: partial response received: 0 bytes". As a result, the output ofspeedtest-netperf.sh -scontains very little data.An optional
-Zor--passphraseoption has been added tospeedtest-netperf.shwhich is passed to the-Zoption of netperf. The-Zoption has been added to usage instructions in script and README.mdWarnings have been put in the script's error output and in the README.md to check the server's web page for a passphrase.
🧪 Run Testing Details
✅ Formalities