Refactor how filtering in MCP tools works #21646
Merged
+67
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters are now defined declaratively during tool definition. In addition to simple where-based filters (like the ones we've been using in SearchProject), we now also support using query filters that are defined for other purposes already. Though we keep supporting custom filtering, since pre-existing classes are often not available and necessary for very simple filtering operations. As a side-find, specs for the ProjectStatusFilter have been extended.
NobodysNightmare
force-pushed
the
mcp_tool_refactor
branch
from
a9a4a9b to
c5783c4
Compare
Kharonus
approved these changes
Jan 22, 2026
Member
Kharonus
left a comment
Kharonus
left a comment
There was a problem hiding this comment.
Codewise I understand the change and find it readable. I have a question for the domain and the responsibilities, though. Maybe you have a quick answer for me?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters are now defined declaratively during tool definition. In addition to simple where-based filters (like the ones we've been using in SearchProject), we now also support using query filters that are defined for other purposes already. Though we keep supporting custom filtering, since pre-existing classes are often not available and necessary for very simple filtering operations.
As a side-find, specs for the ProjectStatusFilter have been extended.
Ticket
This is effectively code maintenance in the scope of https://community.openproject.org/wp/62781