[FSSDK-12169] Build system update #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest Coverage Report
Show files with reduced coverage 🔻
Test suite run success266 tests passing in 10 suites. Report generated by 🧪jest coverage report action from b04bfed |
raju-opti
approved these changes
Jan 16, 2026
rollup.config.mjs
Outdated
| format: 'cjs', | ||
| exports: 'named', | ||
| sourcemap: true, | ||
| globals: { react: 'React' }, |
Contributor
There was a problem hiding this comment.
is this field necessary for non-umd bundles? https://rollupjs.org/configuration-options/#output-globals
rollup.config.mjs
Outdated
| name: 'optimizelyReactSdk', | ||
| exports: 'named', | ||
| sourcemap: true, | ||
| globals: { react: 'React' }, |
Contributor
There was a problem hiding this comment.
previously we had
globals: {
react: 'React',
crypto: 'crypto',
},
does it work without the crypto?
package.json
Outdated
| "directories": { | ||
| "lib": "lib" | ||
| "main": "./dist/react-sdk.min.js", | ||
| "module": "./dist/react-sdk.es.min.js", |
Contributor
There was a problem hiding this comment.
can we get rid of this module entrypoint similar to the JS sdk. Most modern tools should use the exports field anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request modernizes and streamlines the build and CI workflows for the React SDK package. The most significant changes include a complete overhaul of the build system to use a new, unified
rollup.config.js, updates to package outputs and scripts, and improvements to CI workflows for better reliability and speed.Build system modernization and simplification:
scripts/build.js,scripts/winbuild.js, andscripts/config.js) with a new, comprehensiverollup.config.jsthat supports minified/unminified CJS, ESM, and UMD bundles and uses modern Rollup plugin APIs. [1] [2] [3] [4]package.jsonoutputs and exports to use minified bundles by default, added anexportsfield for better ESM/CJS interop, and revised thefilesfield to only include thedistdirectory.package.jsonto clean before building, use Rollup directly, and add a newbuild-umdscript for UMD-only builds.Dependency and tooling updates:
lint-stagedconfiguration to only lint and test files insrc/, and made test runs pass gracefully when no related tests are found.Continuous Integration improvements:
actions/checkoutandactions/setup-node, enabled npm caching, switched fromnpm installtonpm cifor reproducible installs, and standardized on npm as the package manager for coverage reporting. [1] [2] [3] [4]Test plan
Existing test should pass
Issues