[BUGFIX]: resolves saving issue of #3784 #525
Open
+18
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgbernalp
reviewed
Jan 16, 2026
olandr
force-pushed
the
fix/resolve-saving-issue-3784
branch
4 times, most recently
from
948af3e to
589c87b
Compare
olandr
requested review from
AntoineThebaud and
andreasgerstmayr
as code owners
This should resolve the issue with the backend validation for the 'none' values, by not passing down the none at all to the json payload. It keeps using a 'none' label as a default field in the form for UX/clarity. It also removes some redundant objects and variables that are should not be necessary. --------- Signed-off-by: Simon Olander <[email protected]>
olandr
force-pushed
the
fix/resolve-saving-issue-3784
branch
from
589c87b to
275afc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes perses/perses#3784.
This should resolve the issue with the backend validation for the 'none' values, by not passing down the none at all to the json payload. It keeps using a 'none' label as a default field in the form for UX/clarity. It also removes some redundant objects and variables that are should not be necessary.
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes