[ENHANCEMENT] Loki: Improve autocompletion #526
+617
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, autocompletion only worked within log stream selectors. LogQL supports additional pipeline expressions after the stream selector, including line filters (|=, !=, |~, !~) and parser functions (json, logfmt, pattern, regexp, unpack, unwrap). This commit adds context-aware completions for: - Line filter operators after stream selectors - Parser and formatting functions The completion detection is split into detectLabelCompletion() and detectPipeCompletion(). ERROR_NODE cases are handled to provide completions even when syntax is incomplete or malformed. Signed-off-by: Jeremy Rickards <[email protected]>
Signed-off-by: Jeremy Rickards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation uses context-aware detection to provide relevant completions based on query position, and handles incomplete/malformed syntax gracefully. Tests are included to cover the new completion scenarios.
Description
This is a follow-up PR to #496. That PR added autocompletion, but mistakenly only for log stream selectors.
This PR extends autocompletion to support more LogQL:
|=,!=,|~,!~) after stream selectorsjson,logfmt,pattern,regexp,unpack,unwrap)This PR also contains some refactoring to separate label completion and pipe completion into their own functions and helpers. Finally, the PR also adds tests for the completion.
The testing instructions are the same as in #496.
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes