Document setlocale() incompatibility with integer 0 in PHP 8.5 #5094
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jan 13, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
This should be a changelog entry.
Girgias
reviewed
Jan 14, 2026
…e and keep the description free of version-specific notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.5, passing an integer
0as thelocalesargument tosetlocale()is no longer supported and triggers aTypeError.This PR adds a short note to clarify this change and to warn that older examples or user contributed notes may still reference
setlocale(category, 0), which is no longer valid.This helps reduce confusion for users upgrading to PHP 8.5 and copying legacy examples that were historically correct.
Issue #4950