Skip to content

Fix FormattingHandler #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balthild wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −5
Open

Fix FormattingHandler #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
548284c
Fix FormattingHandler
balthild Jan 12, 2026
a46f053
Fix canellation token argument
balthild Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/Handler/TextDocument/FormattingHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

namespace Phpactor\LanguageServer\Handler\TextDocument;

use Amp\CancellationToken;
use Amp\Promise;
use Phpactor\LanguageServerProtocol\FormattingOptions;
use Phpactor\LanguageServerProtocol\DocumentFormattingParams;
use Phpactor\LanguageServerProtocol\ServerCapabilities;
use Phpactor\LanguageServerProtocol\TextDocumentIdentifier;
use Phpactor\LanguageServerProtocol\TextEdit;
use Phpactor\LanguageServer\Core\Formatting\Formatter;
use Phpactor\LanguageServer\Core\Handler\CanRegisterCapabilities;
Expand Down Expand Up @@ -33,12 +33,12 @@ public function methods(): array
/**
* @return Promise<array<int,TextEdit[]>|null>
*/
public function formatting(TextDocumentIdentifier $textDocument, FormattingOptions $options): Promise
public function formatting(DocumentFormattingParams $params, CancellationToken $canellation): Promise
{
return call(function () use ($textDocument) {
return call(function () use ($params) {
$token = WorkDoneToken::generate();
yield $this->notifier->create($token);
$document = $this->workspace->get($textDocument->uri);
$document = $this->workspace->get($params->textDocument->uri);
$this->notifier->begin($token, 'Formatting document');
try {
$formatted = yield $this->formatter->format($document);
Expand Down
Loading