Implement SPED (STUN Protocol for Embedding DTLS) #876
+516
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding `StartDial`, `StartAccept` and `AwaitConnect` methods which allow more control than `Start` and `Accept` This will allow the peer connection API to start DTLS before the ICE connection is established, see pion/webrtc#3335
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (67.26%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
- Coverage 88.27% 87.51% -0.76%
==========================================
Files 43 44 +1
Lines 5509 5705 +196
==========================================
+ Hits 4863 4993 +130
- Misses 451 507 +56
- Partials 195 205 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #861 and #862)
Part of pion/webrtc#3335