Feat/discover #26
Open
Feat/discover #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage ? 84.60%
=======================================
Files ? 12
Lines ? 1065
Branches ? 0
=======================================
Hits ? 901
Misses ? 131
Partials ? 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xinze-zheng
force-pushed
the
feat/discover
branch
from
f77ad6f to
86b0df5
Compare
Member
|
@xinze-zheng This is waiting for your ice PR right? I think we'll be able to finally migrate ice to options tomorrow. |
JoTurk
reviewed
Dec 3, 2025
Comment on lines
+330
to
+373
| func parse(msg *stun.Message, log *slog.Logger) (ret struct { | ||
| xorAddr *stun.XORMappedAddress | ||
| otherAddr *stun.OtherAddress | ||
| respOrigin *stun.ResponseOrigin | ||
| mappedAddr *stun.MappedAddress | ||
| software *stun.Software | ||
| }, | ||
| ) { | ||
| ret.mappedAddr = &stun.MappedAddress{} | ||
| ret.xorAddr = &stun.XORMappedAddress{} | ||
| ret.respOrigin = &stun.ResponseOrigin{} | ||
| ret.otherAddr = &stun.OtherAddress{} | ||
| ret.software = &stun.Software{} | ||
| if ret.xorAddr.GetFrom(msg) != nil { | ||
| ret.xorAddr = nil | ||
| } | ||
| if ret.otherAddr.GetFrom(msg) != nil { | ||
| ret.otherAddr = nil | ||
| } | ||
| if ret.respOrigin.GetFrom(msg) != nil { | ||
| ret.respOrigin = nil | ||
| } | ||
| if ret.mappedAddr.GetFrom(msg) != nil { | ||
| ret.mappedAddr = nil | ||
| } | ||
| if ret.software.GetFrom(msg) != nil { | ||
| ret.software = nil | ||
| } | ||
| for _, attr := range msg.Attributes { | ||
| switch attr.Type { | ||
| case | ||
| stun.AttrXORMappedAddress, | ||
| stun.AttrOtherAddress, | ||
| stun.AttrResponseOrigin, | ||
| stun.AttrMappedAddress, | ||
| stun.AttrSoftware: | ||
| break //nolint:staticcheck | ||
| default: | ||
| log.Debug(fmt.Sprintf("\t%v (l=%v)", attr, attr.Length)) | ||
| } | ||
| } | ||
|
|
||
| return ret | ||
| } |
Member
There was a problem hiding this comment.
Maybe we should just use pion/stun here, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logic for nat behavior discovery (RFC5780). Adapted and modified from pion/stun.
Reference issue
#22