bzlmod: Add MODULE.bazel #490
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
reviewed
Jan 21, 2026
mmorel-35
reviewed
Jan 21, 2026
MODULE.bazel
Outdated
| "dragonbox", | ||
| "fast_float", | ||
| "fp16", | ||
| "highway", |
Contributor
There was a problem hiding this comment.
highway is in BCR : https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/highway as well as fast_float : https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/fast_float
Contributor
Author
There was a problem hiding this comment.
I decided to leave these dependencies in the V8 extension since that way there is a clear link they can be updated and/or added and/or removed together.
mmorel-35
reviewed
Jan 22, 2026
MODULE.bazel
Outdated
| version = "0.0.0", | ||
| ) | ||
|
|
||
| bazel_dep(name = "abseil-cpp", version = "20250814.1") |
Contributor
There was a problem hiding this comment.
Suggested change
| bazel_dep(name = "abseil-cpp", version = "20250814.1") | |
| bazel_dep(name = "abseil-cpp", version = "20250814.1", repo_name = "com_google_absl") |
Can you sort bazel_deps by name, this help keeping it readable and bzlmod doesn"t rely on this order
mmorel-35
reviewed
Jan 22, 2026
MODULE.bazel
Outdated
Comment on lines
31
to
32
| bazel_dep(name = "rules_fuzzing", version = "0.6.0") | ||
| bazel_dep(name = "googletest", version = "1.17.0.bcr.2", repo_name = "com_google_googletest") |
Contributor
There was a problem hiding this comment.
You probably can flag them as dev_dependency, you can group them one line after the main bazel_deps group
mmorel-35
reviewed
Jan 22, 2026
| ) | ||
|
|
||
| # Configure and register the toolchain. | ||
| llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm") |
Contributor
There was a problem hiding this comment.
Suggested change
| llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm") | |
| llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm", dev_dependency = True) |
See https://github.com/bazel-contrib/toolchains_llvm?tab=readme-ov-file#customizations
mmorel-35
reviewed
Jan 22, 2026
| emscripten_deps.config(version = "4.0.17") | ||
|
|
||
| archive_override( | ||
| module_name = "proxy-wasm-cpp-sdk", |
Contributor
There was a problem hiding this comment.
The archive override is local and will need to be also done by dependent first one envoy.
proxy-wasm-cpp-sdk shall be published in BCR.
I wish proxy-wasm/proxy-wasm-cpp-sdk#190 was merged first then a first version can be manually published in the BCR and ready to be used here
mmorel-35
reviewed
Jan 22, 2026
bazel/extensions.bzl
Outdated
Comment on lines
22
to
27
| direct_deps = _wasmtime_crate_repositories() | ||
| return ctx.extension_metadata( | ||
| reproducible = bazel_features.external_deps.extension_metadata_has_reproducible, | ||
| root_module_direct_deps = [dep.repo for dep in direct_deps], | ||
| root_module_direct_dev_deps = [], | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| direct_deps = _wasmtime_crate_repositories() | |
| return ctx.extension_metadata( | |
| reproducible = bazel_features.external_deps.extension_metadata_has_reproducible, | |
| root_module_direct_deps = [dep.repo for dep in direct_deps], | |
| root_module_direct_dev_deps = [], | |
| ) | |
| deps = [] | |
| for repo in _wasmtime_crate_repositories(): | |
| if not repo.is_dev_dep: | |
| deps.append(repo.repo) | |
| return module_ctx.extension_metadata( | |
| reproducible = bazel_features.external_deps.extension_metadata_has_reproducible, | |
| root_module_direct_deps = deps, | |
| root_module_direct_dev_deps = [], | |
| ) |
mmorel-35
reviewed
Jan 22, 2026
bazel/extensions.bzl
Outdated
Comment on lines
34
to
39
| direct_deps = _wasmsign_crate_repositories() | ||
| return ctx.extension_metadata( | ||
| reproducible = bazel_features.external_deps.extension_metadata_has_reproducible, | ||
| root_module_direct_deps = [dep.repo for dep in direct_deps], | ||
| root_module_direct_dev_deps = [], | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| direct_deps = _wasmsign_crate_repositories() | |
| return ctx.extension_metadata( | |
| reproducible = bazel_features.external_deps.extension_metadata_has_reproducible, | |
| root_module_direct_deps = [dep.repo for dep in direct_deps], | |
| root_module_direct_dev_deps = [], | |
| ) | |
| deps = [] | |
| for repo in _wasmsign_crate_repositories(): | |
| if not repo.is_dev_dep: | |
| deps.append(repo.repo) | |
| return module_ctx.extension_metadata( | |
| reproducible = bazel_features.external_deps.extension_metadata_has_reproducible, | |
| root_module_direct_deps = deps, | |
| root_module_direct_dev_deps = [], | |
| ) |
Signed-off-by: Ryan Northey <[email protected]>
Fixes github.com/bazelbuild/bazel/issues/27582 Signed-off-by: Matt Leon <[email protected]>
Changes from 1e1ebdb: * Adds toolchain * Removes unneeded wasmtime crates imports * Adds wasmsign2-cli crates * Adds patch for rules_rust to avoid staticlib linking issue Notably, this change does not use V8 from BCR because V8's MODULE.bazel file is missing various deps (fp16, simdutf, fast_float, intel_ittapi, dragonbox). Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Not all deps need be reachable from the root workspace for bzlmod. Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft PR to run CI on proxy-wasm-cpp-host with MODULE.bazel by default.