Skip to content

Conversation

@moreati
Copy link
Contributor

@moreati moreati commented Jan 19, 2026

fixes #225

@moreati moreati marked this pull request as draft January 19, 2026 14:29
@moreati
Copy link
Contributor Author

moreati commented Jan 19, 2026

I thought I'd introduced some errant underlined whitespace on Github, but the existing README has it too.

Old:
image

New:
image

@moreati moreati marked this pull request as ready for review January 19, 2026 14:34
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pyperf.readthedocs.io/en/latest/run_benchmark.html#install-pyperf still says "pyperf requires Python 3.6 or newer." It should be updated as well.

@moreati
Copy link
Contributor Author

moreati commented Jan 19, 2026

There's also

pyperf git:(issue225) ✗ ag --py "or newer"
pyperf/_linux_memory.py
13:# Need Linux 2.6.16 or newer.

pyperf/_cpu_utils.py
151:    # Python 3.3 or newer?

pyperf/_runner.py
419:                print("Use Python 3.3 or newer, or install psutil dependency")
424:                print("Use Python 3.3 or newer, or install psutil dependency")

I'm happy to do them. Probably best as a new issue and/or PR.

@moreati moreati changed the title README: Update minimum Python version. Add matching badge Docs: Update minimum Python version. Add matching badge Jan 19, 2026
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit e6675c6 into psf:main Jan 19, 2026
12 checks passed
@moreati moreati deleted the issue225 branch January 19, 2026 15:46
@vstinner
Copy link
Member

Merged, thank you for your contribution.

maurycy added a commit to maurycy/pyperf that referenced this pull request Jan 23, 2026
* main:
  Remove fallbacks for unsupported Python versions (< 3.9) (psf#228)
  Docs: Update minimum Python version. Add matching badge (psf#226)
maurycy added a commit to maurycy/pyperf that referenced this pull request Jan 23, 2026
* main:
  Remove fallbacks for unsupported Python versions (< 3.9) (psf#228)
  Docs: Update minimum Python version. Add matching badge (psf#226)
maurycy added a commit to maurycy/pyperf that referenced this pull request Jan 23, 2026
* main:
  Remove fallbacks for unsupported Python versions (< 3.9) (psf#228)
  Docs: Update minimum Python version. Add matching badge (psf#226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: README still says pyperf supports Python >= 3.7

2 participants