-
Notifications
You must be signed in to change notification settings - Fork 91
Docs: Update minimum Python version. Add matching badge #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I thought I'd introduced some errant underlined whitespace on Github, but the existing README has it too. New: |
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://pyperf.readthedocs.io/en/latest/run_benchmark.html#install-pyperf still says "pyperf requires Python 3.6 or newer." It should be updated as well.
|
There's also ➜ pyperf git:(issue225) ✗ ag --py "or newer"
pyperf/_linux_memory.py
13:# Need Linux 2.6.16 or newer.
pyperf/_cpu_utils.py
151: # Python 3.3 or newer?
pyperf/_runner.py
419: print("Use Python 3.3 or newer, or install psutil dependency")
424: print("Use Python 3.3 or newer, or install psutil dependency")I'm happy to do them. Probably best as a new issue and/or PR. |
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merged, thank you for your contribution. |


fixes #225