Scope the remote node token to limit the servers it can manage for backups/transfers #5476
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaneEveritt
added
the
security
Contributor
|
Have you checked that transfers still work? |
Member
Author
|
@QuintenQVD0 are you able to test that for me, I don't have a good setup for that. So far as I can tell they should be fine since the logic checks that either the source/dest node making the request are associated with the transfer. |
Boy132
reviewed
Jan 1, 2026
|
|
||
| $server = $this->repository->getByUuid($uuid); | ||
| if (! $server->node->is($node)) { | ||
| throw new HttpForbiddenException('Requesting node does not have permission to access this server.'); |
Contributor
There was a problem hiding this comment.
This will break transfers: the destination node will call this endpoint and then error because technically the server still belongs to the source node.
For reference: pelican-dev/panel#1680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the security posture of things more by limiting the servers that a node can even communicate about with the Panel.