Open
Conversation
Member
|
As This has some advantages:
However:
As-is, I'm inclined to reject this PR because it opens up a "pandoras box" of edge cases and new feature requests:
However, I'd like to know how I can help future users figure out how to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the script everyone.
Changes
I added a 'folder mode' argument that takes the argument and reads the given directory, then parses the files in it as normal, regardless of file extention.
Why
I had it working on my work macbook (m3), however I was fooling around with it relentlessly on my personal PC (Windows + WSL2). I could not get it working for the life of me with the provided examples or while fooling around with the command.
Does it work?
I tested it on my local windows machine using WSL2 ubuntu 22 with 'moreutils' (for sponge) and 'postgres' installed. Using node v22 I ran the script beneath which resulted in the proper output as I got on my macbook without folder mode.
(folder in example script is ./gtfs including all gtfs.txt files)