Skip to content

gh-143866: Verify return value of pathlib write methods in tests #143870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b9788213 wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −1
Open

gh-143866: Verify return value of pathlib write methods in tests #143870

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be71fed
gh-143866: Verify return value of pathlib write methods in tests
b9788213 Jan 15, 2026
2c25d40
Update existing instead of creating a new one.
b9788213 Jan 15, 2026
8e9c767
Merge branch 'main' into gh-143866-pathlib-test
b9788213 Jan 16, 2026
8b1e0db
.
b9788213 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/test/test_pathlib/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,14 @@ def test_write_bytes(self):
# Check that trying to write str does not truncate the file.
self.assertRaises(TypeError, p.write_bytes, 'somestr')
self.assertEqual(self.ground.readbytes(p), b'abcdefg')
# check the return value
data = b'some bytes'
self.assertEqual(len(data), p.write_bytes(data))
Copy link
Member

@sobolevn sobolevn Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the same here and move the check to the line 68?

Copy link
Author

@b9788213 b9788213 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i will

Copy link
Member

@sobolevn sobolevn Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix the CI.


def test_write_text(self):
p = self.root / 'fileA'
p.write_text('äbcdefg', encoding='latin-1')
data = 'äbcdefg'
self.assertEqual(len(data), p.write_text(data, encoding='latin-1'))
self.assertEqual(self.ground.readbytes(p), b'\xe4bcdefg')
# Check that trying to write bytes does not truncate the file.
self.assertRaises(TypeError, p.write_text, b'somebytes', encoding='utf-8')
Expand Down
Loading