[rl] refactor model registery #2194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jan 2, 2026
meta-cla
bot
added
the
CLA Signed
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
tianyu-l
reviewed
Jan 19, 2026
| f"(model_cls={train_spec.model_cls.__name__}, flavor={model_flavor})" | ||
| ) | ||
| The plugin is loaded at runtime when needed (in generator.py), following | ||
| the pattern used in native_sampler.py. |
Contributor
There was a problem hiding this comment.
where is native_sampler.py?
|
|
||
| This function registers TorchTitan models (e.g., Qwen3) with vLLM's ModelRegistry. | ||
| It's called automatically when the unified module is imported, or can be called | ||
| explicitly for manual registration. |
Contributor
There was a problem hiding this comment.
why do we need the explicit way -- explicitly calling it would require importing in the first place, which would have already register it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):