Package housekeeping #285
Open
Package housekeeping #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failsafe for error 429 Too Many Requests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 89.72% 89.78% +0.06%
==========================================
Files 32 32
Lines 1829 1840 +11
==========================================
+ Hits 1641 1652 +11
Misses 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I merged the PR #284 to this commit to see if the tests run correctly with increased timeout. There was a scb-related timeout here in GitHub whereas the tests worked normally on my own computer |
MansMeg
reviewed
Jan 21, 2026
| pxurl <- build_pxweb_url(px) | ||
| pxqs[[i]] <- pxweb_remove_metadata_from_query(pxqs[[i]], pxmd) | ||
| r <- httr::POST(pxurl, body = pxweb_as_json(x = pxqs[[i]]), pxweb_user_agent(), ...) | ||
| r <- httr::RETRY( |
Contributor
There was a problem hiding this comment.
I think we want to move the times, pa_use etc out as an argument through ellipsis and not hardcode it? Or?
Contributor
|
Hi, Just a small question. Im not sure about the args to RETRY. Maybe have a separate RETRY function through pxweb_advanced_get? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after #282 and #284