Fix imageData.data type
#189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Jan 9, 2026
src/DOMAPI/ImageData.res
Outdated
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/ImageData) | ||
| */ | ||
| @new | ||
| external make2: ( |
Member
There was a problem hiding this comment.
Please rename the function as well while you are here:
Suggested change
| external make2: ( | |
| external makeWithData: ( |
Contributor
Author
|
@nojaf both done |
nojaf
approved these changes
Jan 9, 2026
Member
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Wonderful! Thanks very much.
There should be a new version once CI is done on main.
nojaf
reviewed
Jan 9, 2026
| @@ -0,0 +1,5 @@ | |||
| open DOMAPI | |||
Member
There was a problem hiding this comment.
Could you rename file to ImageData_test.res please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/ImageData/data
I changed it to
Uint8ClampedArray.tbecause initially it wasarray<int>.