add extra kwarg options for File#initialize and derivatives #2798
+129
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The situation where |
Collaborator
|
And we need test code. |
HoneyryderChuck
force-pushed
the
open-extra-options
branch
from
386f3c4 to
df3ce98
Compare
Contributor
Author
|
added. |
this adds the missing kwargs (known as "Open options" and "Encoding options" in the docs) signatures to the following methods, which implemented the same derivative signature: * File#initialize * File.open * Pathname#open
HoneyryderChuck
force-pushed
the
open-extra-options
branch
from
df3ce98 to
b82a4db
Compare
Contributor
Author
|
@ksss anything missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the missing kwargs (known as "Open options" and "Encoding options" in the docs) signatures to the following methods, which implemented the same derivative signature:
As a sidenote, given the number of methods which reimplement the same signature, it'd be great if RBS itself could support some type of annotation to avoid repetition, something like: