riscv-macros: Move post_init attribute
#386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancardenas
force-pushed
the
riscv-macros
branch
6 times, most recently
from
679bfff to
9f1b655
Compare
romancardenas
force-pushed
the
riscv-macros
branch
from
9f1b655 to
92cb29e
Compare
rmsyn
reviewed
Jan 16, 2026
| ); | ||
|
|
||
| #[entry] | ||
| fn main(hartid: usize) -> ! { |
Contributor
There was a problem hiding this comment.
Thanks for adding this test case to the QEMU test suite.
Maybe add cases for positive/negative results for each of the check_* functions to the test-trybuild suite?
Contributor
Author
There was a problem hiding this comment.
Sure! There are already a few, but I am also thinking on a new error handling mechanism for these macros that stores multiple errors and throws them in batch. In this way, developers will able to see all the errors with just one attempt
romancardenas
force-pushed
the
riscv-macros
branch
from
9b5d742 to
288b98c
Compare
Contributor
Author
|
@rmsyn check it out, I think the new error handling is way better than in previous versions! |
romancardenas
force-pushed
the
riscv-macros
branch
from
288b98c to
d86e58d
Compare
Contributor
Author
|
(of course Rust 1.93 came with new clippy lints and compile error messages that broke our CI...) |
romancardenas
force-pushed
the
riscv-macros
branch
2 times, most recently
from
d08b712 to
79c47a6
Compare
romancardenas
force-pushed
the
riscv-macros
branch
from
79c47a6 to
8049a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the rework for procedural macros of the RISC-V crates. Basically, it migrates
riscv_rt_macros::post_inittoriscv_macros::post_init.The behavior of the macro remains mainly identical. However, I worked on a more modular implementation, with the idea of reusing as much code as possible once this PR is merged and we move
entry,exception, etc. Hopefully, it will be easier in the future to maintain all theriscv-rtmacros :)I also modified the
multi-hartQEMU example to illustrate how the macro works (and assert that it works properly).Let me know what you think!