Fixes for redis.call("info") #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would fail with - ``` NoMethodError: undefined method 'i' for an instance of MockRedis::Database mock_redis-0.52.0/lib/mock_redis/database.rb:58:in 'Kernel#public_send' mock_redis-0.52.0/lib/mock_redis/database.rb:58:in 'MockRedis::Database#call' mock_redis-0.52.0/lib/mock_redis/multi_db_wrapper.rb:21:in 'MockRedis::MultiDbWrapper#method_missing' mock_redis-0.52.0/lib/mock_redis/expire_wrapper.rb:17:in 'MockRedis::ExpireWrapper#method_missing' mock_redis-0.52.0/lib/mock_redis/transaction_wrapper.rb:25:in 'MockRedis::TransactionWrapper#method_missing' mock_redis-0.52.0/lib/mock_redis/pipelined_wrapper.rb:27:in 'MockRedis::PipelinedWrapper#method_missing' mock_redis-0.52.0/lib/mock_redis.rb:95:in 'block in MockRedis#method_missing' mock_redis-0.52.0/lib/mock_redis.rb:151:in 'MockRedis#logging' mock_redis-0.52.0/lib/mock_redis.rb:94:in 'MockRedis#method_missing' ``` I've updated the way `call` handles its arguments, to just flatten them into a single array regardless of length.
In redis-rb:
- redis.info() returns a parsed Hash
- redis.call("info") returns a raw string
I've added a info_raw method, and updated `call` to use it for info commands.
jdelStrother
force-pushed
the
call-info
branch
from
eda1e1c to
5b587d7
Compare
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
call(:info)would fail:I fixed that by flattening the arguments passed to
Database#call... but noticed that actually,call(:info)ought to return a raw string rather than a parsed hash. How about something like this?