-
Notifications
You must be signed in to change notification settings - Fork 3
Fix restart functionality to clone requests instead of overwriting existing entries #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
20
commits into
main
Choose a base branch
from
copilot/fix-73-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: benhegartysefe <[email protected]>
Co-authored-by: benhegartysefe <[email protected]>
Copilot
AI
changed the title
[WIP] 304267 - restart request is overwriting the existing entry instead of new entry on the dorc monitor section
Fix restart functionality to clone requests instead of overwriting existing entries
Jul 24, 2025
Contributor
|
@slafeer-sefe please could you review and complete? |
Collaborator
|
if we are restarting the request why is the original request shown as completed? it can be confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The restart functionality was overwriting existing deployment request entries instead of creating new ones, which caused loss of deployment history and made it impossible to track the original request execution.
Issue: When restarting a deployment request, the system would:
This approach overwrote the original request data and execution history.
Solution
Implemented a clone-based restart mechanism that preserves the original request while creating a new one for execution:
Backend Changes
Added clone functionality to
IRequestsPersistentSource:Implemented cloning logic in
RequestsPersistentSourcethat:Modified
RequestController.RestartPostto use cloning instead of status modification:Frontend Changes
Updated user messaging to reflect the new behavior:
Backward Compatibility
/Request/restart)Result
Before:
After:
The restart functionality now creates a new cloned request instead of modifying the existing one, preserving deployment history while enabling re-execution with the same configuration.
Fixes #73.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.