-
Notifications
You must be signed in to change notification settings - Fork 67
Fix: DNSSEC - return SERVFAIL when signed zone omits RRSIG #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: DNSSEC - return SERVFAIL when signed zone omits RRSIG #447
Conversation
Signed-off-by: Maciek <[email protected]>
Signed-off-by: Maciek <[email protected]>
|
Can you skip |
Signed-off-by: Maciek <[email protected]>
Signed-off-by: Maciek <[email protected]>
Signed-off-by: Maciek <[email protected]>
…TCP-TLS) Signed-off-by: Maciek <[email protected]>
|
@semihalev Looks like forwarder_test was failing because of upstream DNS failure resolutions; I have created mock DNS server in forwarder package test and injected |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 80.16% 80.37% +0.21%
==========================================
Files 77 77
Lines 8942 8960 +18
==========================================
+ Hits 7168 7202 +34
+ Misses 1376 1358 -18
- Partials 398 400 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
A small linter issue detected, after the fix looks everything good. |
Signed-off-by: Maciek <[email protected]>
Summary:
Fix DNSSEC nosig: SERVFAIL when signed zone omits RRSIG
Fail closed on missing RRSIG when delegation is secure (DS present)
Map to SERVFAIL with EDE RRSIGsMissing
Update resolver and handler tests for nosig dnscheck case