[6.x] Use ResolveValues to resolve values in EloquentQueryBuilder::pluck()
#13726
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix an issue with the Eloquent Driver where an error would occur when updating entries in a search index.
We're plucking the
referencefrom entries in the entries searchable here:cms/src/Search/Searchables/Entries.php
Line 46 in 8563d35
However, when entries are stored in the database, this results in an array of
nullvalues becausereferenceisn't a "real" column in the database.This PR adopts the fix suggested in statamic/eloquent-driver#531, where we use
ResolveValuesto resolve values inEloquentQueryBuilder::pluck(), allowing it to actually hit `Entry::reference().Fixes statamic/eloquent-driver#531