Skip to content

Conversation

@DhruvArvindSingh
Copy link
Contributor

@DhruvArvindSingh DhruvArvindSingh commented Jan 12, 2026


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: skipped
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: skipped
  • task: lint_javascript_benchmarks status: skipped
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: skipped
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • Adds JS implementation of @stdlib/blas/base/srotmg
  • Adds Fortran implementation of @stdlib/blas/base/srotmg
  • Adds C implementation of @stdlib/blas/base/srotmg
  • Adds Tests , Benchmarks and Examples for C, Fortran and JS

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • In this PR i have implemented srotmg main and assign function in C with 6 and 7 arguments respectively
void c_srotmg( const float d1, const float d2, const float x1, const float y1, float *out, const CBLAS_INT strideOut );
void c_srotmg_assign( const float d1, const float d2, const float x1, const float y1, float *out, const CBLAS_INT strideOut, const CBLAS_INT offsetOut );
  • In this PR i have implemented srotmg.f code by taking reference from LAPACK LINK
void srotmg( float *, float *, float *, const float *, float * );

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: skipped
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: skipped
  - task: lint_javascript_benchmarks
    status: skipped
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: skipped
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Jan 12, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 12, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/srotmg $\color{red}450/498$
$\color{green}+0.00%$
$\color{red}31/34$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{red}450/498$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter self-requested a review January 13, 2026 05:07
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR!

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 13, 2026
@DhruvArvindSingh
Copy link
Contributor Author

DhruvArvindSingh commented Jan 13, 2026

Hey @Planeshifter i have made the necessary changes which was needed, just for understanding i am getting the below equality warnings while creating the addon.node and build folder, it is not causing any fortran working problem but i am not able to understand the root cause of it. I have taken reference from LINK

gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make[1]: Entering directory '/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/build'
  RULE binding_gyp_addon_target_compile_fortran_linux_0 Release/obj.target/addon/geni/srotmg.o
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/src/srotmg.f:92:8:

   92 |     if ( sp2 .eq. zero ) then
      |        1
Warning: Equality comparison for REAL(4) at (1) [-Wcompare-reals]
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/src/srotmg.f:152:8:

  152 |     if ( sd1 .ne. zero ) then
      |        1
Warning: Inequality comparison for REAL(4) at (1) [-Wcompare-reals]
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/src/srotmg.f:154:12:

  154 |         if ( sflag .eq. zero ) then
      |            1
Warning: Equality comparison for REAL(4) at (1) [-Wcompare-reals]
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/src/srotmg.f:177:8:

  177 |     if ( sd2 .ne. zero ) then
      |        1
Warning: Inequality comparison for REAL(4) at (1) [-Wcompare-reals]
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/src/srotmg.f:179:12:

  179 |         if ( sflag .eq. zero ) then
      |            1
Warning: Equality comparison for REAL(4) at (1) [-Wcompare-reals]
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/src/srotmg.f:206:12:

  206 |   else if ( sflag .eq. zero ) then
      |            1
Warning: Equality comparison for REAL(4) at (1) [-Wcompare-reals]
  CC(target) Release/obj.target/addon/src/addon.o
  CC(target) Release/obj.target/addon/src/srotmg_f.o
  CC(target) Release/obj.target/addon/../shared/src/main.o
  CC(target) Release/obj.target/addon/../../../strided/base/min-view-buffer-index/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-float/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/is-type/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/equal-types/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-int64/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-strided-float32array/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-float32array/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/equal-typedarray-types/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/is-typedarray/src/main.o
  CC(target) Release/obj.target/addon/../../../strided/base/stride2offset/src/main.o
  SOLINK_MODULE(target) Release/obj.target/addon.node
  COPY Release/addon.node
  ACTION Copying addon... src/addon.node
  TOUCH Release/obj.target/copy_addon.stamp
make[1]: Leaving directory '/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/base/srotmg/build'
gyp info ok 

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 13, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants