Skip to content

Bugfix: multisite token logic #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
defunctl wants to merge 137 commits into
base: main
Choose a base branch
from
Draft

Bugfix: multisite token logic #51

defunctl wants to merge 137 commits into from

Conversation

@defunctl
Copy link
Contributor

@defunctl defunctl commented Dec 1, 2023 •
edited
Loading

Main Changes

This PR completely changes the way Uplink treats multisite installations. See the new multisite licensing documentation.

  • All token storing/disconnecting logic now requires a Resource slug in order to test whether the plugin is network activated or not, so we know where to store the token.
  • Lots of new helper functions to provide a common interface for accessing Uplink functionality.

Other

  • Fixes failing Replacement_Key tests due to renaming of base API url.

@defunctl defunctl self-assigned this Dec 1, 2023
@defunctl defunctl added the bug Something isn't working label Dec 1, 2023
defunctl added 16 commits December 1, 2023 17:02
@defunctl
Refactor Authorized
3346f9c
@defunctl
WIP: conditional token storage
a65371d
@defunctl
WIP: multisite logic refactor
d14edea
@defunctl
Add get_license_key function
46f3eb4
@defunctl
Reset multisite config to original state after each test
521a8a0
@defunctl
Refactor get_domain() to take into consideration unique subsites when…
0270487 
… in subfolder mode
@defunctl
Remove token check, replace with main site check
1e2f595
@defunctl
Add Config::allows_network_licenses() and update Multisite_Main_Site.php
4438ee2
@defunctl
Add a hash suffix to the main site URL when on multisite with network…
16ef300 
… licenses
@defunctl
Delete old pipeline steps
8d27445
@defunctl
Add more helper functions
a9b95be
@defunctl
Rename get_domain function
86325a0
@defunctl
Move disconnect URL into its own method, add helper function
5a267e8
@defunctl
Allow getting the original domain name
f1fad44
@defunctl
Get original domain for download args
92f883c
@defunctl
Remove get_token, update get_authorization_token
a12acd1
@defunctl defunctl mentioned this pull request Dec 6, 2023
Merged
@defunctl defunctl added this to the 2.0.0 milestone Dec 6, 2023
benjaminritner and others added 28 commits December 3, 2024 16:10
@benjaminritner
Fix array
0f8f4b8
@benjaminritner
Add test
007ca4b
@benjaminritner
fix string
6983bea
@benjaminritner
target..
bb787f2
@benjaminritner
Merge pull request #89 from stellarwp/bugfix/missing-filter
301a5d4 
Add expired message filter
@benjaminritner
Account for an empty siteurl in the database
d134ede
@benjaminritner
apply change
82d3e19
@benjaminritner
Merge pull request #93 from stellarwp/bugfix/empty-domain
f33e2d3 
Bugfix/empty domain
@benjaminritner
fix so filter works
0633114
@benjaminritner
update the get_license_key function to be able to get from a file
addd780
@benjaminritner
Fix in the license field
6895615
@benjaminritner
Merge pull request #97 from stellarwp/fix/get-key-from-file
0002d91 
update the get_license_key function to be able to get from a file
@benjaminritner
cache is auth
919946a
@benjaminritner
It's possible token is an empty string so lets add each to this.
3df24c1
@benjaminritner
fix test
03de24f
@benjaminritner
use error
3ec669f
@benjaminritner
remove error response that won't work
bdf59ec
@defunctl
Merge branch 'bugfix/multisite-token-logic' into feat/cache-is-auth
cdf9980
@benjaminritner @defunctl
Update tests/wpunit/API/V3/AuthorizerCacheTest.php
e98f26c 
Co-authored-by: Justin <defunctl@users.noreply.github.com>
@benjaminritner @defunctl
Update tests/wpunit/API/V3/AuthorizerCacheTest.php
c5bb75e 
Co-authored-by: Justin <defunctl@users.noreply.github.com>
@benjaminritner
Justin suggestion
7d64abb
@benjaminritner
Merge pull request #98 from stellarwp/feat/cache-is-auth
032fdd7 
Add caching to a false response for is auth to prevent requests every page load.
@benjaminritner
fix for cache miss
898dc04 
get_transient doesn't return an integer, so we need to store and test against a string
@defunctl
Update to use constants
404a2d7
@benjaminritner
Merge pull request #99 from stellarwp/bug/fix-auth-cache
8fa2db9 
fix for cache miss
@benjaminritner
allow overriding info specific to wp format
b9ab80a
@benjaminritner
update for php
0866cfd
@borkweb
Merge pull request #95 from stellarwp/bugfix/api_base_url_filter
12f341b 
Bugfix/api base url filter
@dave-green-uk
Copy link
Contributor

dave-green-uk commented Dec 18, 2025

@defunctl do you know what (if anything) is blocking this being reviewed and merged?

We could use it for: https://github.com/iconicwp/iconic-core/pull/50#issuecomment-3670503301

@defunctl
Copy link
Contributor Author

defunctl commented Dec 18, 2025

@defunctl do you know what (if anything) is blocking this being reviewed and merged?

We could use it for: iconicwp/iconic-core#50 (comment)

Hey @dave-green-uk Basically I created this for Kadence in a hurry to launch the AI licensing.

Because it's such a major change, I'm not sure how many sites it could affect/break if merged. I just know that Kadence does currently uses this branch in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@borkweb borkweb borkweb requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@defunctl defunctl

Labels

bug Something isn't working

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@defunctl @dave-green-uk @borkweb @benjaminritner