-
Notifications
You must be signed in to change notification settings - Fork 135
Add failure summary to ConsoleOutputRecorder #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tienquocbui
wants to merge
19
commits into
swiftlang:main
Choose a base branch
from
tienquocbui:gsoc-development4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
27cebcf
Add failure summary to ConsoleOutputRecorder. Implemented end-of-run …
tienquocbui 07b934d
Add severity tracking to IssueInfo struct and factor failure summary …
tienquocbui 3ce9059
nit: whitespace
stmontgomery fd4bfb9
Fix warning about unnecessary var
stmontgomery 43ee2f9
Include an environment variable to control whether the failure summar…
stmontgomery 3dd24e9
TestRunSummary doesn't need to be `@_spi public`, it can be `private`
stmontgomery 1f2c45e
Use the `counting(_:)` utility to pluralize nouns
stmontgomery d21e05f
Correct comment about "debug" description, specifically
stmontgomery acedae2
Fix error in my earlier change which adopted 'counting', and rephrase…
stmontgomery f8480e0
fixup: whitespace
stmontgomery cfd89ad
Simplify by beginning variable with initial value
stmontgomery 7123fd6
Omit the module name on complete paths for tests
stmontgomery 241c268
Indent source location of issues one level deeper and use the CustomS…
stmontgomery 2025bc8
Use severity >= .error instead of == .error
stmontgomery 4a5299f
Refactor to simplify and consolidate some logic in fullyQualifiedName()
stmontgomery 56871cf
whitespace
stmontgomery d28ad7f
Remove unnecessary 'public' access level
stmontgomery dd6105b
Fix parameterized test display and group test cases under parent test…
tienquocbui a371a1e
Add labels and move failure summary to end of output
tienquocbui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could potentially be a suite, for example if the issue was recorded by a TestScoping trait applied to a suite, so ideally we would conditionalize the word "Test" to use "Suite" instead in that scenario