Skip to content

Remove workaround for fatalError() call in Mutex trylock function. #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grynspan wants to merge 1 commit into from
Closed

Remove workaround for fatalError() call in Mutex trylock function. #1488

grynspan wants to merge 1 commit into from

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 17, 2026 •
edited
Loading

This PR removes a workaround for an errant fatalError() call in the Linux implementation of Mutex.withLockIfAvailable(). That call was removed by swiftlang/swift#85448 which is in the Swift 6.3 and 6.4-dev (main) branches.

Do not merge this PR to release/6.3 as it will not work with the Swift 6.2 toolchain.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Remove workaround for fatalError() call in Mutex trylock function.
62eefca 
This PR removes a workaround for an errant `fatalError()` call in the Linux
implementation of `Mutex.withLockIfAvailable()`. That call was removed by
swiftlang/swift#85448 which is in the Swift 6.3 and
6.4-dev (main) branches.
@grynspan grynspan added this to the Swift 6.4.0 (main) milestone Jan 17, 2026
@grynspan grynspan self-assigned this Jan 17, 2026
@grynspan grynspan added the concurrency 🔀 Swift concurrency/sendability issues label Jan 17, 2026
@grynspan grynspan requested a review from jerryjrchen as a code owner January 17, 2026 03:16
@grynspan grynspan added linux 🐧 Linux support (all distros) workaround Workaround for an issue in another component (may need to revert later) tech-debt 💾 reduces technical debt labels Jan 17, 2026
@grynspan
Copy link
Contributor Author

grynspan commented Jan 17, 2026

Fails as expected on Linux with the 6.2 toolchain.

@grynspan
Copy link
Contributor Author

grynspan commented Jan 20, 2026

Superseded by #1481.

@grynspan grynspan closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen is a code owner

Assignees

@grynspan grynspan

Labels

concurrency 🔀 Swift concurrency/sendability issues linux 🐧 Linux support (all distros) tech-debt 💾 reduces technical debt workaround Workaround for an issue in another component (may need to revert later)

Projects

None yet

Milestone

Swift 6.4.0 (main)

Development

Successfully merging this pull request may close these issues.

2 participants

@grynspan @stmontgomery