[SILVerifier] Adjust ownership requirement for `ImplicitActorToOpaque… #86567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a fix for the issue currently blocking #85518 |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test Windows platform |
Contributor
|
@xedin can you add a SIL test case that shows that this works as intended. |
Contributor
Author
|
Sure, I'm figuring out how to do that at the moment. |
…IsolationCast` This check should use `isCompatibleWith` because sometimes the operands don't have ownership i.e. when the actor is `nil`. Resolves: rdar://164993540
…olationCast` Similarly to SILVerifier condition, it has to use `isCompatibleWith` to allow for "none" as well.
Contributor
Author
|
@swift-ci please smoke test |
gottesmm
approved these changes
Jan 15, 2026
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…IsolationCast`
This check should use
isCompatibleWithbecause sometimes the operands don't have ownership i.e. when the actor isnil.Resolves: rdar://164993540