Editorial: Provide override of NonISODateLastDayOfMonth #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tc39/proposal-temporal#3208. This would be the corresponding definition of NonISODateLastDayOfMonth using the calendar-specific operations defined in this proposal.
sffc
reviewed
Jan 9, 2026
Collaborator
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
Do you plan to use the new AO in the multiple places in spec.emu that call BalanceNonISODate to achieve this goal?
Collaborator
Author
|
I looked at doing that. This operation needs to convert from ISO date to calendar date and back, whereas the other two places where we call BalanceNonISODate don't need that. Of course, implementations can just elide those conversions, or we could refactor things so that it made more sense to deduplicate the BalanceNonISODate calls. But I didn't want to put too much time in it right at this moment since I'm not 100% sure this PR is necessary for tc39/proposal-temporal#3208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-temporal#3208. This would be the corresponding definition of NonISODateLastDayOfMonth using the calendar-specific operations defined in this proposal.