-
Notifications
You must be signed in to change notification settings - Fork 172
Polyfill: Check that time is not start-of-day in ToTemporalInstant #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The TemporalInstantString production requires a Time, so `time` will never be `start-of-day` in this code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
==========================================
+ Coverage 96.75% 97.90% +1.14%
==========================================
Files 22 22
Lines 10398 10365 -33
Branches 1859 1815 -44
==========================================
+ Hits 10061 10148 +87
+ Misses 289 198 -91
+ Partials 48 19 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can make the same change in the spec text, in ToTemporalInstant step 6.
Co-authored-by: Philip Chimento <[email protected]>
Done in 4392a0a |
Co-authored-by: Philip Chimento <[email protected]>
ptomato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The TemporalInstantString production requires a Time, so
timewill never bestart-of-dayin this code.