feature: Add control indicators for Compounds in SequenceEditor#233
Open
colelawrence wants to merge 2 commits intomainfrom
Open
feature: Add control indicators for Compounds in SequenceEditor#233colelawrence wants to merge 2 commits intomainfrom
colelawrence wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
colelawrence
force-pushed
the
feature/2022-06/add-aggregate-cursor-nav-in-sequence-editor
branch
from
fb63b0e to
267dc71
Compare
colelawrence
requested review from
AriaMinaei and
vezwork
and removed request for
AriaMinaei
vezwork
approved these changes
Jun 24, 2022
Contributor
vezwork
left a comment
vezwork
left a comment
There was a problem hiding this comment.
Code LGTM. Product-wise I think its decent enough to merge and come back to. Its slightly strange that the buttons are to the left of the name as opposed to to the right on the leaf props, but it maintains the visual hierarchy which I like. Would defer comments/further changes to others trying it out once its merged tho.
Contributor
Author
|
Added @AriaMinaei to review to verify that it's okay to start with the UI shown in screenshot. |
Contributor
Author
|
Now waiting on design to confirm what to do with right aligning styles from Mariusz
|
colelawrence
force-pushed
the
feature/2022-06/add-aggregate-cursor-nav-in-sequence-editor
branch
from
dab8e65 to
5f8887e
Compare
vezwork
added
the
next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally written up at Add compound keyframe addition via sequence editor (add keyframe cursors to compound sheet row)
Cole.s.screen.capture.of.Playground.Theatre.js.2022-06-24.at.10.48.02.mp4