Merged
Conversation
ethe
requested changes
Feb 4, 2026
src/db/scan.rs
Outdated
| }; | ||
| let row_set = match prune_result.row_selection().cloned() { | ||
| Some(selection) => { | ||
| let total_rows = if row_groups.is_empty() { |
Member
There was a problem hiding this comment.
this uses file_total_rows when row_groups.is_empty(), but empty means "all pruned", not "all kept". This creates RowSet::all(file_total_rows) for fully-pruned SSTs.
Collaborator
Author
There was a problem hiding this comment.
Yes, you’re right. row_groups.is_empty() means fully pruned, so using file_total_rows was wrong and created RowSet::all(file_total_rows) for skipped SSTs. I’ve fixed it to size the row set using only kept row-group rows, and I now skip SSTs with empty row sets at plan time. Added a regression test plan_scan_skips_fully_pruned_sst.
# Conflicts: # src/db/scan.rs
* feat: wire parquet pushdown execution * fix: keep residual predicate for schema-mismatched ssts * refactor: avoid predicate columns in sst-only scans
ethe
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
RowSetabstraction (total_rows + RowSelection) and wired it throughScanPlanfor mutable, immutable, and SST sources.Tests
cargo testcargo clippy -- -D warnings