Skip to content

refactor: rely on auto Send/Sync for DbInner#577

Merged
ethe merged 1 commit intomainfrom
remove-unsafe-dbinner-send-sync
Feb 4, 2026
Merged

refactor: rely on auto Send/Sync for DbInner#577
ethe merged 1 commit intomainfrom
remove-unsafe-dbinner-send-sync

Conversation

@belveryin
Copy link
Collaborator

Summary

  • Remove manual unsafe impl Send/Sync for DbInner so auto-trait checks enforce thread-safety based on fields.
  • Let the compiler catch non-Send/Sync additions instead of masking them.

Testing

  • cargo +nightly fmt --all -- --check
  • cargo clippy --workspace -- -D warnings
  • cargo build --verbose
  • cargo test --verbose
  • cargo llvm-cov --workspace --lcov --output-path target/coverage/lcov.info --fail-under-lines 80
  • cargo test public_api_e2e:: -- --nocapture

@belveryin belveryin requested a review from ethe February 3, 2026 19:25
@ethe
Copy link
Member

ethe commented Feb 4, 2026

I'm not sure if this can be compiled on WASM, I'd like to fix ci trigger firstly and then check it

@ethe ethe force-pushed the remove-unsafe-dbinner-send-sync branch from f9e1c2e to ef4b360 Compare February 4, 2026 06:39
@ethe ethe merged commit e3aa4c7 into main Feb 4, 2026
6 checks passed
@ethe ethe deleted the remove-unsafe-dbinner-send-sync branch February 4, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants