Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 28, 2026

I really want remove them completely since it has a maintainance cost, but broken cksum is one of a blocker for hashsum deletion. So I fix it.

Closes #10002

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

Merging this PR will degrade performance by 99.77%

❌ 1 regressed benchmark
✅ 141 untouched benchmarks
⏩ 180 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cksum_blake3 216.1 µs 93,266 µs -99.77%

Comparing oech3:ckb3 (acbef91) with main (42b2ad8)

Open in CodSpeed

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Jan 28, 2026

Note that we are benchmarking a bunch of errors currently. So regression is not happening.

@oech3 oech3 mentioned this pull request Jan 31, 2026
@github-actions
Copy link

github-actions bot commented Feb 1, 2026

GNU testsuite comparison:

GNU test failed: tests/ls/abmon-align. tests/ls/abmon-align is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3
Copy link
Contributor Author

oech3 commented Feb 2, 2026

ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cksum: unknown algorithm: blake3: clap should have prevented this case

1 participant