Skip to content

cksum family: Backport new errors for --binary, --text and --tag #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oech3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cksum family: Backport new errors for --binary, --text and --tag #10618

oech3 wants to merge 1 commit into from

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 31, 2026 •
edited
Loading

Closes #10130
Closes #10623 ?

@oech3 oech3 mentioned this pull request Jan 31, 2026
Closed
@github-actions
Copy link

github-actions bot commented Jan 31, 2026

GNU testsuite comparison:

GNU test failed: tests/cksum/b2sum. tests/cksum/b2sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum. tests/cksum/cksum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-base64. tests/cksum/cksum-base64 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-raw. tests/cksum/cksum-raw is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-sha3. tests/cksum/cksum-sha3 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3 oech3 marked this pull request as draft January 31, 2026 10:55
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 31, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing oech3:cksum-new (6016288) with main (26498f5)

Summary

✅ 142 untouched benchmarks
⏩ 180 skipped benchmarks1

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Jan 31, 2026

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?

@oech3 oech3 force-pushed the cksum-new branch 2 times, most recently from c190aaa to 557af54 Compare January 31, 2026 12:13
@oech3

This comment was marked as resolved.

Sign in to view
@github-actions
Copy link

github-actions bot commented Jan 31, 2026

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jan 31, 2026

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-c. tests/cksum/cksum-c is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review January 31, 2026 16:48
@oech3
Copy link
Contributor Author

oech3 commented Jan 31, 2026

See #10623 . Regression was caused by backport.

@oech3 oech3 force-pushed the cksum-new branch 3 times, most recently from f215b6a to fb74f2a Compare January 31, 2026 17:13
@oech3
Copy link
Contributor Author

oech3 commented Jan 31, 2026 •
edited
Loading

from_standalone splitation is painful for clap...

@github-actions
Copy link

github-actions bot commented Jan 31, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

oech3
oech3 commented Jan 31, 2026
View reviewed changes
src/uu/checksum_common/src/lib.rs
.flatten();

let format = OutputFormat::from_standalone(std::env::args_os());
//todo: deduplicate matches.get_flag
Copy link
Contributor Author

@oech3 oech3 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RenjiSann

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

GNU testsuite comparison:

GNU test failed: tests/ls/abmon-align. tests/ls/abmon-align is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cksum (backport): Wrong error message priority cksum family: Backport --text --tag and --binary --tag --untagged behavior from main of GNU

1 participant

@oech3