chore: update ignoredBuiltDependencies list
#1022
Merged
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
pnpm installfor this project will currently show a warning:This PR adds those 3 dependencies to
ignoredBuiltDependencies, which suppresses that warning.simple-git-hooksdoesn't need to run because we also have"prepare": "simple-git-hooks"inpackage.json, which already runs during an install. Listing it inonlyBuiltDependencieswould lead to it running twice, which is harmless but unnecessary.As far as I'm aware,
yorkieand@parcel/watcherare transient dependencies and we don't need them to run during an install.I've also moved both
onlyBuiltDependenciesandignoredBuiltDependenciestopnpm-workspace.yaml, rather than having them inpackage.json. When pnpm 10.0.0 was first released, the release notes recommended addingonlyBuiltDependenciestopackage.json, which is what #810 did. But there were various changes and additions to the feature in later v10 releases. I thinkpnpm-workspace.yamlis the more natural home for pnpm-specific configuration and is wherepnpmsaves them by default when runningpnpm approve-builds(docs).