Skip to content

Conversation

@skirtles-code
Copy link
Contributor

Running pnpm install for this project will currently show a warning:

Ignored build scripts: @parcel/watcher, simple-git-hooks, yorkie.
Run "pnpm approve-builds" to pick which dependencies should be allowed to run scripts.

This PR adds those 3 dependencies to ignoredBuiltDependencies, which suppresses that warning.

simple-git-hooks doesn't need to run because we also have "prepare": "simple-git-hooks" in package.json, which already runs during an install. Listing it in onlyBuiltDependencies would lead to it running twice, which is harmless but unnecessary.

As far as I'm aware, yorkie and @parcel/watcher are transient dependencies and we don't need them to run during an install.

I've also moved both onlyBuiltDependencies and ignoredBuiltDependencies to pnpm-workspace.yaml, rather than having them in package.json. When pnpm 10.0.0 was first released, the release notes recommended adding onlyBuiltDependencies to package.json, which is what #810 did. But there were various changes and additions to the feature in later v10 releases. I think pnpm-workspace.yaml is the more natural home for pnpm-specific configuration and is where pnpm saves them by default when running pnpm approve-builds (docs).

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 035db08
🔍 Latest deploy log https://app.netlify.com/projects/vue-devtools-docs/deploys/695cacb6dc2d3a0008f2eea3

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 11, 2026

Open in StackBlitz

@vue/devtools-applet

npm i https://pkg.pr.new/@vue/devtools-applet@1022

@vue/devtools-core

npm i https://pkg.pr.new/@vue/devtools-core@1022

@vue/devtools

npm i https://pkg.pr.new/@vue/devtools@1022

@vue/devtools-api

npm i https://pkg.pr.new/@vue/devtools-api@1022

@vue/devtools-kit

npm i https://pkg.pr.new/@vue/devtools-kit@1022

vite-plugin-vue-devtools

npm i https://pkg.pr.new/vite-plugin-vue-devtools@1022

commit: 035db08

@webfansplz webfansplz merged commit a4be9d4 into vuejs:main Jan 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants