Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.16.10. See astro PR #15200.

@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 2801251
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6970da011bbaa500087e5f32
😎 Deploy Preview https://deploy-preview-13047--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 14, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First sentence feels like it could be a little better if we wanted, but then, good to go when you're happy!

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jan 14, 2026
@sarah11918
Copy link
Member

(As I think I mentioned elsewhere, I didn't realize this was a draft when I reviewed it! I saw how tiny it was and thought I could squeeze it in waiting for other update branch/checks. 😅 So, I'll "un-approve" it, but only because it's not done!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this un-approve?

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

@sarah11918 sarah11918 dismissed their stale review January 15, 2026 17:29

If I dismiss, will I have unapproved?

@florian-lefebvre florian-lefebvre marked this pull request as ready for review January 19, 2026 13:29
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super close! Just made a note to make sure it's the right release number, an d there's one sentence that doesn't make sense and I'm not sure what it's supposed to be, but this will be good to go really soon!

Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a nit regarding src, because we're using it in the code snippet and maybe it would be better to explicitly specify this is an array in the description?

And, I guess at one point we'll need to document format and tech too. But this is NWTWWHB, so LGTM. 😄

export interface FontData {
	src: Array<{ url: string; format?: string; tech?: string }>;
	weight?: string;
	style?: string;
}

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks both!

@florian-lefebvre florian-lefebvre merged commit dd34d4a into main Jan 21, 2026
9 of 10 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-data-object branch January 21, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants