fix: use safe YAML parsing to prevent RCE vulnerability #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes typ="unsafe" to typ="safe" in init_similar_cache_from_config() to prevent arbitrary code execution via malicious config files. Fixes zilliztech#676 Signed-off-by: karthik <[email protected]>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kxbnb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/assign @cxie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the RCE vulnerability reported in #676 by changing
typ="unsafe"totyp="safe"ininit_similar_cache_from_config().Changes
YAML(typ="unsafe", pure=True)toYAML(typ="safe", pure=True)ingptcache/adapter/api.pyWhy this is safe
The config file only needs to load plain data (strings, dicts, lists, numbers). Safe YAML handles all of these. The
unsafemode was never needed - it just allowed arbitrary Python object instantiation which is the root cause of the vulnerability.Testing
ConstructorErrorFixes #676