ui: Make metadata per machine-trace #4571
Open
+1,112
−225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21500386404-1-ui/ui/index.html |
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/machine_metadata
branch
from
7882a07 to
0ea4ed1
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/ui_machine_metadata
branch
2 times, most recently
from
98aab8a to
aad7568
Compare
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/ui_machine_metadata
branch
from
24c2a3f to
96ae7b2
Compare
LalitMaganti
approved these changes
Jan 29, 2026
src/trace_processor/perfetto_sql/intrinsics/functions/metadata.cc
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/std/metadata/summary.sql
Outdated
Show resolved
Hide resolved
CHROME_STDLIB_MANUAL_ROLL=f
CHROME_STDLIB_MANUAL_ROLL=f
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/machine_metadata
branch
from
35c434d to
e7a7663
Compare
sashwinbalaji
commented
Jan 29, 2026
Member
Author
There was a problem hiding this comment.
also fyi for now made _metadata_for_primary_scope private to unblock.
Reason being without that ALLOWED_TOPLEVEL_PUBLIC_PACKAGES in https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:external/perfetto/tools/check_sql_modules.py others like https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:external/perfetto/python/generators/sql_processing/stdlib_tags.py would need to add std so will make it public once your approval
Member
|
That's fine you're ok to add std to the list of allowed top level packages tho keeping it private is also ok. |
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/ui_machine_metadata
branch
from
96ae7b2 to
e1e6853
Compare
CHROME_STDLIB_MANUAL_ROLL=f
sashwinbalaji
force-pushed
the
dev/sashwinbalaji/machine_metadata
branch
from
e8fc969 to
b03e78b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.