Handle packed params #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
judithroth
reviewed
Jan 16, 2026
judithroth
left a comment
judithroth
left a comment
There was a problem hiding this comment.
So far this looks good to me! I also tried it locally and it works.
src/extensions/openProjectApi.ts
Outdated
| readonly, | ||
| } = verifyToken(token); | ||
|
|
||
| console.log({ token, resourceUrl, tokenResourceUrl, authToken, readonly }); |
There was a problem hiding this comment.
You're probably aware that this is still here and remove it before merge 🙂
judithroth
approved these changes
Jan 16, 2026
judithroth
approved these changes
Jan 19, 2026
judithroth
left a comment
judithroth
left a comment
There was a problem hiding this comment.
As said when we discussed, I would have preferred an different approach. But as this seems not to be easily doable with Hocuspocus, I'm ok with the current approach.
I tested both PRs locally and it works 👍
Good work!
| }); | ||
|
|
||
| test("when the token is invalid throw an error", async () => { | ||
| test("when the packedParams is expired", async () => { |
Contributor
Author
|
Close in favour of #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of opf/openproject#21706
What are you trying to accomplish?
Package parameters from rails counterpart so that we can properly validate them in Hocuspocus
What approach did you choose and why?
The parameters are packaged into a JWT using symmetric signatures to allow validation.
Merge checklist