Package hocuspocus sync parameters #21706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@judithroth @akabiru asking for an early review, not sure if this is how it's going to look when ready |
3 tasks
Contributor
Contributor
Author
You're right 🤦, my bad. Too many things at once. I editted the message |
judithroth
reviewed
Jan 16, 2026
Contributor
judithroth
left a comment
judithroth
left a comment
There was a problem hiding this comment.
So far this looks good for me! It would be nice to also have some tests here, but I think that could be a separate PR so we get this out faster.
| resource_url: @resource_url, | ||
| oauth_token:, | ||
| readonly: @readonly, | ||
| exp: 20.minutes.from_now.to_i |
Contributor
There was a problem hiding this comment.
If this only expires the token_payload, not the token itself, I think 20 minutes are too long. I'd rather go for 5 minutes here.
| @@ -43,7 +43,7 @@ | |||
| component.with_main(classes: "op-document-view--main") do | |||
| flex_layout(align_items: :center) do |flex| | |||
| flex.with_row(classes: "op-document-view--header") do | |||
| render Documents::ShowEditView::PageHeaderComponent.new(document, project:, state:, readonly:) | |||
| render Documents::ShowEditView::PageHeaderComponent.new(document, project:, state:) | |||
judithroth
approved these changes
Jan 16, 2026
brunopagno
force-pushed
the
impl/70603-pack-hocuspocus-sync-params
branch
from
aa20c31 to
7a1b660
Compare
judithroth
approved these changes
Jan 19, 2026
Contributor
Author
|
Closing in favour of #21720 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of opf/op-blocknote-hocuspocus#32
What are you trying to accomplish?
Package parameters from rails counterpart so that we can properly validate them in Hocuspocus
What approach did you choose and why?
The parameters are packaged into a JWT using symmetric signatures to allow validation.
Merge checklist