Skip to content

Conversation

@SimeonGriggs
Copy link
Contributor

@SimeonGriggs SimeonGriggs commented Jan 13, 2026

Changes

  • role create - updated error message
  • role list - updated error message
  • role reset-default - updated error message

Before

pscale role create typo-database main app
Error: branch main does not exist in database typo-database (organization: my-org)

After

pscale role create typo-database main app
Error: database typo-database or branch main does not exist in organization my-org

Question:

This follows the pattern used in keyspace/create.go and keyspace/list.go.

An alternative approach would be to first check if the database exists (like branch/show.go does), which would allow more precise error messages. However, that adds an extra API call on the error path. Happy to implement that approach if preferred.

@SimeonGriggs SimeonGriggs requested a review from a team as a code owner January 13, 2026 15:44
@mscoutermarsh mscoutermarsh force-pushed the fix/role-not-found-error-message branch from 3966f01 to 9e828a7 Compare January 13, 2026 18:16
@mscoutermarsh mscoutermarsh merged commit 1b33e41 into main Jan 13, 2026
2 checks passed
@mscoutermarsh mscoutermarsh deleted the fix/role-not-found-error-message branch January 13, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants